chrishkchris commented on issue #552: SINGA-496 Implement softplus and softsign functions for tensor math URL: https://github.com/apache/singa/pull/552#issuecomment-554625840 This is the running result of test case: ``` ubuntu@ip-172-31-16-93:~/incubator-singa/build/bin$ ./test_singa Running main() from gtest_main.cc [==========] Running 242 tests from 48 test cases. [----------] Global test environment set-up. [----------] 71 tests from TensorMath . . . [ RUN ] TensorMath.SignCpp [ OK ] TensorMath.SignCpp (0 ms) [ RUN ] TensorMath.SoftPlusCpp /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:127: Failure The difference between 0.0f and dptr[0] is 1, which exceeds 1e-5, where 0.0f evaluates to 0, dptr[0] evaluates to 1, and 1e-5 evaluates to 1.0000000000000001e-05. /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:128: Failure The difference between 1.0f and dptr[1] is 1, which exceeds 1e-5, where 1.0f evaluates to 1, dptr[1] evaluates to 2, and 1e-5 evaluates to 1.0000000000000001e-05. /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:132: Failure Value of: dptr1[0] Actual: 0.693147 Expected: log(2.0f) Which is: 0.693147 /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:133: Failure Value of: dptr1[1] Actual: 1.31326 Expected: log(exp(1) + 1.0f) Which is: 1.31326 [ FAILED ] TensorMath.SoftPlusCpp (0 ms) [ RUN ] TensorMath.SoftSignCpp /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:140: Failure The difference between 0.0f and dptr[0] is 1, which exceeds 1e-5, where 0.0f evaluates to 0, dptr[0] evaluates to 1, and 1e-5 evaluates to 1.0000000000000001e-05. /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:141: Failure The difference between 1.0f and dptr[1] is 1, which exceeds 1e-5, where 1.0f evaluates to 1, dptr[1] evaluates to 2, and 1e-5 evaluates to 1.0000000000000001e-05. /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:146: Failure Value of: dptr1[1] Actual: 0.5 Expected: 1.0f / 3 Which is: 0.333333 [ FAILED ] TensorMath.SoftSignCpp (0 ms) . . . [ RUN ] TensorMath.BroadcastCuda [ OK ] TensorMath.BroadcastCuda (6 ms) [ RUN ] TensorMath.SoftPlusCuda /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:1243: Failure Value of: log(2.0f) Actual: 0.693147 Expected: dptr[0] Which is: 0.693147 /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:1244: Failure Value of: log(exp(1) + 1.0f) Actual: 1.31326 Expected: dptr[1] Which is: 1.31326 [ FAILED ] TensorMath.SoftPlusCuda (5 ms) [ RUN ] TensorMath.SoftSignCuda /home/ubuntu/incubator-singa/test/singa/test_tensor_math.cc:1259: Failure Value of: 1.0f / 3 Actual: 0.333333 Expected: dptr[1] Which is: 0.5 [ FAILED ] TensorMath.SoftSignCuda (5 ms) . . . [----------] 71 tests from TensorMath (188 ms total) . . . [----------] Global test environment tear-down [==========] 242 tests from 48 test cases ran. (59883 ms total) [ PASSED ] 238 tests. [ FAILED ] 4 tests, listed below: [ FAILED ] TensorMath.SoftPlusCpp [ FAILED ] TensorMath.SoftSignCpp [ FAILED ] TensorMath.SoftPlusCuda [ FAILED ] TensorMath.SoftSignCuda 4 FAILED TESTS ``` Please check the complete logic of the test cases SoftPlus, SoftSign using the definition of the softplus and softsign. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
