chrishkchris commented on issue #552: SINGA-496 Implement softplus and softsign functions for tensor math URL: https://github.com/apache/singa/pull/552#issuecomment-558432861 Thanks! I have double checked by building and running the test cases, where no problem is found. The code looks good to me (LGTM) and my review is completed. ``` ubuntu@ip-172-31-36-70:~/incubator-singa/build/bin$ ./test_singa Running main() from gtest_main.cc [==========] Running 242 tests from 48 test cases. [----------] Global test environment set-up. . . . [ RUN ] TensorMath.SoftPlusCuda [ OK ] TensorMath.SoftPlusCuda (6 ms) [ RUN ] TensorMath.SoftSignCuda [ OK ] TensorMath.SoftSignCuda (5 ms) [----------] 71 tests from TensorMath (194 ms total) . . . [----------] Global test environment tear-down [==========] 242 tests from 48 test cases ran. (60064 ms total) [ PASSED ] 242 tests. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
