nudles commented on a change in pull request #624: SINGA-487 Include NCCL and
MPICH in conda build
URL: https://github.com/apache/singa/pull/624#discussion_r394065182
##########
File path: tool/conda/singa/build.sh
##########
@@ -31,9 +31,16 @@ else
USE_CUDA=ON
fi
+
+if [ $DIST == "ON" ]; then
+ USE_DIST=ON
+else
+ USE_DIST=OFF
+fi
+
mkdir build
cd build
cmake -DCMAKE_INSTALL_PREFIX=$PREFIX -DUSE_CUDA=$USE_CUDA \
- -DUSE_PYTHON3=ON -DUSE_MKLDNN=ON
-DCMAKE_OSX_SYSROOT=${CONDA_BUILD_SYSROOT} ..
+ -DUSE_PYTHON3=ON -DUSE_DNNL=OFF -DUSE_DIST=$USE_DIST
-DCMAKE_OSX_SYSROOT=${CONDA_BUILD_SYSROOT} ..
Review comment:
USE_DNNL is a variable whose value depends on the environment. It should not
be hard coded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
