[
https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595023#comment-14595023
]
wangwei commented on SINGA-21:
------------------------------
It would be better to review and clean the files one by one instead of sending
the pull request after all files are cleaned.
Because new features are being added recently, there would be many changes to
the code base. Consequently, there would be many conflicts when we merge the
pull request after cleaning all code. If we do it one by one, it would be much
easier since there are fewer conflicts.
We may consider abbreviate some variable names to make the code tidy. Due to
the length limit (80 characters per line), we have to break one statement into
multiple lines if the variable names are long. Some common abbreviations
include {noformat} group --> grp, nservers_per_group --> grp_size, target -->
trgt {noformat}.
> Code Review
> -----------
>
> Key: SINGA-21
> URL: https://issues.apache.org/jira/browse/SINGA-21
> Project: Singa
> Issue Type: Task
> Reporter: Sheng Wang
> Assignee: Sheng Wang
>
> Clean the code for first release.
> Code style follows google c++ code
> style(https://google-styleguide.googlecode.com/svn/trunk/cppguide.html).
> Style check tool
> cpplint(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py)
> is recommanded to help clean the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
