[
https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701311#comment-14701311
]
ASF subversion and git services commented on SINGA-21:
------------------------------------------------------
Commit b24f0a32dd55c43b274e021ab4a53011943f83c7 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=b24f0a3 ]
SINGA-21 Code review 3
review cluster.h, cluster.cc
-- change the first Get() of cluster to Setup()
-- change shared pointers to raw pointers
-- let cluster be a singleton
-- remove unused endpoints_ field
-- format the code
In cluster_rt.h/cc
-- remove CluterRuntime interface
-- rename ZKClusterRT to ClusterRuntime
> Code Review
> -----------
>
> Key: SINGA-21
> URL: https://issues.apache.org/jira/browse/SINGA-21
> Project: Singa
> Issue Type: Task
> Reporter: Sheng Wang
> Assignee: Sheng Wang
>
> Clean the code for first release.
> Code style follows google c++ code
> style(https://google-styleguide.googlecode.com/svn/trunk/cppguide.html).
> Style check tool
> cpplint(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py)
> is recommanded to help clean the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
