Yes thanks a bunch Joe! A
On Nov 26, 2012, at 8:57 PM, Mattmann, Chris A (388J) wrote: > Hi Joe, > > Great job! > > 0. Please file a ticket, here: > > http://issues.apache.org/jira/browse/SIS > > Then you can attach your patch to that issue. > To create the patch: > > 1. svn co http://svn.apache.org/repos/asf/sis/<branch>/ > 2. cd <branch> > 3. edit files and add files > 4. svn add any new files > 5. svn status (make sure looks ok) > 6. svn diff > SIS-xxx.jwhite.112612.patch.txt where xxx is the issue ID # > from 0 > 7. attach patch to issue from 0. > > Done! > > Cheers, > Chris > > On Nov 26, 2012, at 7:30 PM, Joe White wrote: > >> Hey, guys, >> I've completed the skeleton class, and implemented most of the methods >> according to the documentation in the original email. I'm not 100% sure if >> I can check it in, but if not, I'll submit a patch on this thread. Right >> now, I'm working on the unit tests for each of the implemented methods. I >> should be done tonight or tomorrow at the latest. >> >> Joe >> On Nov 25, 2012, at 2:15 PM, "Mattmann, Chris A (388J)" >> <[email protected]> wrote: >> >>> Hey Guys, >>> >>> Fine by me -- if there hasn't been movement by mid-next-week I'll pick this >>> up. >>> >>> Cheers, >>> Chris >>> >>> On Nov 25, 2012, at 10:41 AM, Adam Estrada wrote: >>> >>>> Hi Joe, >>>> >>>> By all means go right ahead! Your contributions are greatly appreciated. >>>> >>>> AdamJoe White <[email protected]> wrote:Hi, all, >>>> >>>> If no one minds, I'll take a look at this one. I've been neglecting SIS, >>>> and this will get me back into the swing of things. >>>> >>>> Joe >>>> On Nov 25, 2012, at 11:14 AM, "Mattmann, Chris A (388J)" >>>> <[email protected]> wrote: >>>> >>>>> Hey Martin, >>>>> >>>>> If no one beats me to this by mid next week I'll take care of it. >>>>> >>>>> Cheers, >>>>> Chris >>>>> >>>>> On Nov 25, 2012, at 12:35 AM, Martin Desruisseaux wrote: >>>>> >>>>>> Hello all >>>>>> >>>>>> I started to port more metadata classes on my local machine, but I'm >>>>>> still hitting dependencies. Yesterday I have hit the first dependency >>>>>> having a (minor) licensing issue. To be legally safe, I think it would >>>>>> be preferable to have a volunteer for providing an initial commit of the >>>>>> class described below. I only need the initial commit; from that point >>>>>> all subsequent commits were our own. A volunteer could commit that on >>>>>> trunk, JDK6 or JDK7 branch at his convenience. >>>>>> >>>>>> I would like a Range class in the following location: >>>>>> >>>>>> sis-utility/src/main/java/org/apache/sis/measure/Range.java >>>>>> >>>>>> The API of this Range class would be almost identical the the Java >>>>>> Advanced Imaging Range class. In fact, this Range class has been added >>>>>> in old GeoTools time in replacement to the JAI one, in order to reduce >>>>>> JAI dependency: >>>>>> >>>>>> http://download.java.net/media/jai/javadoc/1.1.3/jai-apidocs/javax/media/jai/util/Range.html >>>>>> >>>>>> However the initial commit doesn't need to be a fully functional Range >>>>>> implementation. In particular, I suggest to omit isEmpty(), subtract, >>>>>> equals, hashCode and toString methods since we already have material for >>>>>> those methods that we can merge after the initial commit. Javadoc can >>>>>> also be omitted except for one or two class introduction sentences. >>>>>> >>>>>> I have wrote in more details what need to be done there: >>>>>> >>>>>> https://svn.apache.org/repos/asf/sis/ip-review/Range.xhtml >>>>>> >>>>>> Click on the last link ("Range implementation hooked up") - one can see >>>>>> a more detailed description of what needs to be done. Peoples >>>>>> considering to volunteer should probably not read past the blue line >>>>>> with the "Revision 29950" title in it. >>>>>> >>>>>> We would also need a JUnit RangeTest class, to be written from scratch... >>>>>> >>>>>> Regards, >>>>>> >>>>>> Martin >>>>>> >>>>> >>>> >>> >> >
