+1, happy to commit and iterate! Great work all.
Cheers, Chris On Nov 29, 2012, at 9:13 AM, Martin Desruisseaux wrote: > Hello Joe > > Thanks you very much for the patch, this is well appreciated! > > On a minor topic, it would probably we worth to declare the fields as final. > It would also be cool to apply the generic parameters to the Comparable > interface. One can take inspiration from this JDK method in order to see how > it can be done: > > http://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#binarySearch%28java.util.List,%20T%29 > > But anyway, Adam or other volunteer can commit if they wish, then we could do > a few rounds. > > Martin > > > > Le 29/11/12 11:18, Joe White a écrit : >> Gentlemen, >> I've added the issue and then added the patch. I did probably go a little >> overboard on some of the testing, and I did implement some of the items >> that weren't really on the list. One thing I did not implement was the >> Serializable interface. I did make it a little closer to the jai interface, >> using Comparable. This lets the environment take care of the comparisons >> for us, making it a little cleaner. If there is more work to be done, >> please let me know. I'd be glad to help out where ever I can. >> >> Joe >
