desruisseaux commented on a change in pull request #23:
URL: https://github.com/apache/sis/pull/23#discussion_r656929804
##########
File path:
core/sis-feature/src/main/java/org/apache/sis/filter/ComparisonFunction.java
##########
@@ -95,13 +103,34 @@
* @param isMatchingCase specifies whether comparisons are case
sensitive.
* @param matchAction specifies how the comparisons shall be
evaluated for a collection of values.
*/
- ComparisonFunction(final Expression expression1, final Expression
expression2, final boolean isMatchingCase, final MatchAction matchAction) {
+ ComparisonFunction(final Expression<? super R, ?> expression1,
+ final Expression<? super R, ?> expression2,
+ final boolean isMatchingCase, final MatchAction
matchAction)
+ {
super(expression1, expression2);
this.isMatchingCase = isMatchingCase;
this.matchAction = matchAction;
ArgumentChecks.ensureNonNull("matchAction", matchAction);
}
+ /**
+ * Returns the element on the left side of the comparison expression.
+ * This is the element at index 0 in the {@linkplain #getExpressions()
list of expressions}.
+ */
+ @Override
+ public final Expression<? super R, ?> getOperand1() {
+ return expression1;
+ }
+
+ /**
+ * Returns the element on the left side of the comparison expression.
+ * This is the element at index 0 in the {@linkplain #getExpressions()
list of expressions}.
Review comment:
Yes you are right, this is a copy-and-paste error. Thanks for spotting!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
