desruisseaux commented on a change in pull request #23:
URL: https://github.com/apache/sis/pull/23#discussion_r656933835
##########
File path:
core/sis-feature/src/main/java/org/apache/sis/filter/LeafExpression.java
##########
@@ -248,13 +159,38 @@ public PropertyTypeBuilder expectedType(FeatureType
ignored, final FeatureTypeBu
* Invoked when a new attribute type need to be created for the given
standard type.
* The given standard type should be a GeoAPI interface, not the
implementation class.
*/
- private static <T> AttributeType<T> newType(final Class<T>
standardType) {
+ private static <R> AttributeType<R> newType(final Class<R>
standardType) {
return createType(standardType, Names.createLocalName(null, null,
"Literal"));
}
+ }
+
+
+
+
Review comment:
A single line is used between methods, but in this case it is a
separation between bigger entities (inner classes). I have no strong opinion
about what should be the formatting guideline in those cases however. If there
is a well-established practice I would be happy to apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
