ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437 URL: https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362199137 I found some question about this PR, here are the questions: Q1: I use the [demo](https://github.com/lytscu/skywalking-agent-testcases/tree/servicecomb/servicecomb-0.x-scenario) to trace the service about Servicecomb, I found the trace is broken, The consumer trace segment should be like the following: ``` Span-0: codefirstClient.codeFirstSpringmvcHello.say Span-1: codefirst.codeFirstHello.sayHi ``` but in fact those spans are in two segments. Q2: The buried point `Invocation` is more complex, I found some buried point about Servicecomb plugin will more simple. **Consumer side**: 1. `io.servicecomb.common.rest.RestProducerInvocation#createInvocation` 2. `io.servicecomb.common.rest.AbstractRestInvocation#invoke` The `Pojo` way about Servicecomb 1. `io.servicecomb.provider.pojo.Invoker#invoke` **Producer Side**: 1. `io.servicecomb.swagger.engine.SwaggerProducerOperation#invoke`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
