ascrutae commented on issue #771: Add [Agent] ServiceComb Plugin #437 URL: https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362509001 @wu-sheng Sorry for my poor english, and here is my explain. I use the demo to enhance ServicceComb and found that the trace is broken. Here is the expected segment about demo: ``` ServiceComb-Segment: Span-0: `codefirstClient.codeFirstSpringmvcHello.say` Span-1: `codefirst.codeFirstHello.sayHi` ``` In fact the generated segment looks like this: ``` SerivceComb-Segment-0: Span-0: `codefirstClient.codeFirstSpringmvcHello.say` ServiceComb-Segment-1: Span-0: `codefirst.codeFirstHello.sayHi` ``` The question is cause by the buired point is incorrect. Because of the enhance method `next` finished before the service method invoked. I found some suggest enhance class about `REST` service. But the ServiceComb support multiple way to provide service, maybe @lytscu still find the similar enhance class. **Consumer side** `io.servicecomb.common.rest.RestProducerInvocation#invoke`: The entry method about REST way to provide service. `io.servicecomb.provider.pojo.Invoker#invoke`: The entry method about ServiceComb RPC client stub .(The demo in call ServiceComb service by PRC) **Producer side** `io.servicecomb.core.handler.impl.ProducerOperationHandler#handle`: The entry method about RPC service stub.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
