I will send PR Assuming that we will introduce a new black list property called 'disable_plugins' in agent.config to list comma separated keys to plugin ids to be disabled.
Below is an example. #the below will disable activemq-5.x-plugin & armeria-0.84.x-plugin disable_plugins=activemq-5.x,armeria-063-084 I am also thinking to introduce a white list property called 'enable_plugins' in agent.config to list comma separated keys to plugin ids to be enabled. NOTE that 'enable_plugins' property takes precedence over 'disable_plugins' and when 'enable_plugins' is in agent.config 'disable_plugins' property is ignored. #the below will enable ON:Y elasticsearch-6.x-plugin & rabbitmq-5.x-plugin; NOTE that disable_plugins is ignored when enable_plugins is in agent.config enable_plugins=elasticsearch-6.x,rabbitmq-5.x Let me know what you think On Sat, Mar 28, 2020 at 11:18 PM Sheng Wu <[email protected]> wrote: > Hi Vr Vlaa > > It seems NO objection from the team. you could work on this and look > forward to your pull request. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > han liu <[email protected]> 于2020年3月27日周五 下午9:44写道： > >> I think add the configuration item in `agent.conf` to close plugins is >> looking good to me. >> >> In this way, both configuration file and environment variables can be take >> effect after restarted the application. >> >> >> Vr Vlaa <[email protected]>于2020年3月27日 周五下午9:23写道： >> >> > I am fine with listing plugin names in agent.config to disable instead >> of >> > feeding via skywalking-plugin.def in that format. As long as we have a >> way >> > to disable plugins via agent.config, it handles this requirement. >> > >> > >> > On Fri, Mar 27, 2020 at 8:24 AM Sheng Wu <[email protected]> wrote: >> > >> > > Hi Dev team >> > > >> > > There is a discussion happening on GitHub issue. I hope that could >> > > continue on the mail list. >> > > >> > > Vr Vlaa wants to add a mechanism to disable plugin without physical >> > > deletion. I propose to keep using agent.config file and the names in >> the >> > > plugin.def files. >> > > >> > > I want to hear more from others from dev team. >> > > >> > > Sheng Wu >> > > >> > > Vr Vlaa <[email protected]>于2020年3月27日 周五下午8:19写道： >> > > >> > >> ---------- Forwarded message --------- >> > >> From: 吴晟 Wu Sheng <[email protected]> >> > >> Date: Fri, Mar 27, 2020 at 7:47 AM >> > >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins >> > >> (#4578) >> > >> To: apache/skywalking <[email protected]> >> > >> Cc: viswaramamoorthy <[email protected]>, Author < >> > >> [email protected]> >> > >> >> > >> >> > >> I prefer you still use the agent.config to deactivate, by listing the >> > >> disable plugin names. You should notice all plugin.def includes >> names, >> > You >> > >> should use those names to disable agent plugins. >> > >> >> > >> WDYT? >> > >> >> > >> And, this discussion should happen in the mail list, could you >> forward >> > >> there? >> > >> >> > >> — >> > >> You are receiving this because you authored the thread. >> > >> Reply to this email directly, view it on GitHub >> > >> < >> > https://github.com/apache/skywalking/issues/4578#issuecomment-604957166 >> > >> >, >> > >> or unsubscribe >> > >> < >> > >> >> > >> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA >> > >> > >> > >> . >> > >> >> > > -- >> > > Sheng Wu 吴晟 >> > > >> > > Apache SkyWalking >> > > Apache Incubator >> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings >> > > Zipkin >> > > Twitter, wusheng1108 >> > > >> > >> >
