Inline. Viswa Ramamoorthy <[email protected]>于2020年3月30日 周一下午8:52写道：
> Yes. I gave have seen it. But in a release plugin keys would stay the same. > Right? The only case I know, which has the name changed, is due to adopting new version of libraries. So, They change the existing plugin name, such as adding the latest version number in the name. But still, this is not a normal case. > > Ideally plugins could be given a ID that can be a separate enhancement in a > new release. I think basically, It is still same. Because people can't predict the future, can't tell which part of the plugin would be incompatible.😂 > > On Mon, Mar 30, 2020, 6:25 AM kezhenxu94 <[email protected]> wrote: > > > > > > > > 在 2020年3月27日，20:25，Sheng Wu <[email protected]> 写道： > > > > > > Hi Dev team > > > > > > There is a discussion happening on GitHub issue. I hope that could > > continue > > > on the mail list. > > > > > > Vr Vlaa wants to add a mechanism to disable plugin without physical > > > deletion. I propose to keep using agent.config file and the names in > the > > > plugin.def files. > > > > > > > It’s ok to use the key in .def files, but as a reminder, the keys are not > > strict rules and is subject to change > > > > > I want to hear more from others from dev team. > > > > > > Sheng Wu > > > > > > Vr Vlaa <[email protected]>于2020年3月27日 周五下午8:19写道： > > > > > >> ---------- Forwarded message --------- > > >> From: 吴晟 Wu Sheng <[email protected]> > > >> Date: Fri, Mar 27, 2020 at 7:47 AM > > >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins > > >> (#4578) > > >> To: apache/skywalking <[email protected]> > > >> Cc: viswaramamoorthy <[email protected]>, Author < > > >> [email protected]> > > >> > > >> > > >> I prefer you still use the agent.config to deactivate, by listing the > > >> disable plugin names. You should notice all plugin.def includes names, > > You > > >> should use those names to disable agent plugins. > > >> > > >> WDYT? > > >> > > >> And, this discussion should happen in the mail list, could you forward > > >> there? > > >> > > >> — > > >> You are receiving this because you authored the thread. > > >> Reply to this email directly, view it on GitHub > > >> < > > https://github.com/apache/skywalking/issues/4578#issuecomment-604957166 > >, > > >> or unsubscribe > > >> < > > >> > > > https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA > > >>> > > >> . > > >> > > > -- > > > Sheng Wu 吴晟 > > > > > > Apache SkyWalking > > > Apache Incubator > > > Apache ShardingSphere, ECharts, DolphinScheduler podlings > > > Zipkin > > > Twitter, wusheng1108 > > > > > > > > > > -- Sheng Wu 吴晟 Apache SkyWalking Apache Incubator Apache ShardingSphere, ECharts, DolphinScheduler podlings Zipkin Twitter, wusheng1108
