Hi, On 29.07.2010 08:45, Carsten Ziegeler wrote: > Felix Meschberger wrote >> Hi, >> >> It took me some time to complete, but here we are... >> >> I have finished SLING-1193 (Resource API extension) and SLING-1575 >> (moving Authenticator interface to Sling API). >> > Great, thanks for the work Felix! > >> I think this finishes all open tasks for Sling 2.1.0. Looking back at >> what we did, this looks like the biggest extension to API since 2.0 ;-) >> >> Before cutting a release, lets wait few days for people to review the API. >> > Ok, here we go :) > > I think the AuthenticationInfo is something which might move to the > Sling API - when using the ResourceResolverFactory to get a resolver, it > would be a little bit nicer to be able to use the AuthenticationInfo > class instead of a plain map (for using the constructors and the constants).
Agreed for the constants: How about moving them to the API ? Why is using the AuthenticationInfo constructor more elegant than using the Map constructor and setting a property. And where would such a thing be used ? > > I can't remember our old discussions in detail, but I thought we move > the api part (including the spi) from the auth module to the Sling api > module and just leave the implementation in the auth module. > So basically the problematic part is the auth module which contains api > and impl. > The urge to change this is not that high as it only affects people using > the Sling API without the Auth module, but still it would be nice :) My point was, that the SPI part of the Commons Auth API is more tied to how the Commons Auth bundle implements the org.apache.sling.api.auth API. As such it is of no interest to most Sling Application developers. Regards Felix > > Regards > Carsten
