[ 
https://issues.apache.org/jira/browse/SLING-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230692#comment-17230692
 ] 

Bertrand Delacretaz commented on SLING-9903:
--------------------------------------------

bq. this applies to the Sling Servlet Annotations IT as well

Good point, I had a quick look and those tests might be testing more than just 
the annotations generation - which is not a fantastic idea in terms of 
separation of concerns but if that's correct we might want to keep them. I've 
made a note of this!

> Validate the generated OSGi metatada instead of running a Sling instance
> ------------------------------------------------------------------------
>
>                 Key: SLING-9903
>                 URL: https://issues.apache.org/jira/browse/SLING-9903
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Adapter Annotations 2.0.0
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>
> I took another look at the 
> https://github.com/apache/sling-org-apache-sling-adapter-annotations and 
> considering that the annotations act at build time only (together with the 
> bnd plugin) I don't think we need to start a Sling instance to validate them.
> I'll prepare a PR that checks the XML files generated in the OSGI-INF folder, 
> that should be sufficient.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to