[
https://issues.apache.org/jira/browse/SLING-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230766#comment-17230766
]
Bertrand Delacretaz commented on SLING-9903:
--------------------------------------------
bq. the {{servlets-annotations-it}} tests might be testing more than just the
annotations generation..
Confirmed,
[ServletRegistrationIT|https://github.com/apache/sling-org-apache-sling-servlets-annotations-it/blob/master/src/test/java/org/apache/sling/servlets/annotations/ServletRegistrationIT.java]
for example tests some servlet resolver functionality.
I prefer leaving that as is and having a few redundant tests there that might
expose bugs not seen elsewhere than cleaning up for tests performance and
"purity". We might revisit if we make substantial changes to the
servlet-annotations module later.
> Validate the generated OSGi metatada instead of running a Sling instance
> ------------------------------------------------------------------------
>
> Key: SLING-9903
> URL: https://issues.apache.org/jira/browse/SLING-9903
> Project: Sling
> Issue Type: Improvement
> Components: Engine
> Affects Versions: Adapter Annotations 2.0.0
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Adapter Annotations 2.0.2
>
>
> I took another look at the
> https://github.com/apache/sling-org-apache-sling-adapter-annotations and
> considering that the annotations act at build time only (together with the
> bnd plugin) I don't think we need to start a Sling instance to validate them.
> I'll prepare a PR that checks the XML files generated in the OSGI-INF folder,
> that should be sufficient.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
