karlpauls commented on a change in pull request #43:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/43#discussion_r540335944
##########
File path:
src/test/java/org/apache/sling/feature/cpconverter/accesscontrol/AclManagerTest.java
##########
@@ -109,7 +101,50 @@ public void
makeSureAclsAreCreatedOnlyoutsideSytemUsersPaths() throws Exception
// "set ACL for
acs-commons-package-replication-status-event-service\n" +
// "allow jcr:read,crx:replicate,jcr:removeNode on
/asd/public\n" +
// "end\n" +
- "set ACL for acs-commons-ensure-oak-index-service" +
System.lineSeparator() +
+ "set ACL for
acs-commons-package-replication-status-event-service" + System.lineSeparator() +
+ "allow jcr:read,rep:write,rep:indexDefinitionManagement on
/asd/not/system/user/path" + System.lineSeparator() +
+ "end" + System.lineSeparator();
+ String actual = repoinitExtension.getText();
+ assertEquals(expected, actual);
+
+ RepoInitParser repoInitParser = new RepoInitParserService();
+ List<Operation> operations = repoInitParser.parse(new
StringReader(actual));
+ assertFalse(operations.isEmpty());
+ }
+
+ @Test
+ public void testRest() throws RepoInitParsingException {
Review comment:
yup
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
