karlpauls commented on a change in pull request #43:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/43#discussion_r540337331
##########
File path:
src/test/java/org/apache/sling/feature/cpconverter/accesscontrol/AclManagerTest.java
##########
@@ -120,6 +155,37 @@ public void
makeSureAclsAreCreatedOnlyoutsideSytemUsersPaths() throws Exception
assertFalse(operations.isEmpty());
}
+ @Test
+ public void testAddACLforUnknownUser() throws RepoInitParsingException {
+ aclManager.addSystemUser(new
SystemUser("acs-commons-package-replication-status-event-service", new
RepoPath("/home/users/system/foo"), new RepoPath("/home/users/system")));
Review comment:
good idea - in that case the extension should be null because it doesn't
have anything. I'll change that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]