I propose to no longer activate the plugin by default. It currently checks for existence of both LICENSE and NOTICE files in all attached artifacts.
For JAR artifacts this is not necessary: For NOTICE this is always done via the sling-parent pom.xml (https://github.com/apache/sling-parent/blob/525ef3128cccc22c39624229158375104a131849/sling-parent/pom.xml#L182 <https://github.com/apache/sling-parent/blob/525ef3128cccc22c39624229158375104a131849/sling-parent/pom.xml#L182>) For LICENSE we can use https://maven.apache.org/enforcer/enforcer-rules/requireFilesExist.html <https://maven.apache.org/enforcer/enforcer-rules/requireFilesExist.html> instead to make sure it always exists on the root level of the repository (a check not yet performed by IANAL). Its existence is also ensured by https://maven.apache.org/apache-resource-bundles/index.html <https://maven.apache.org/apache-resource-bundles/index.html> being included in https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L335 <https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L335>. For ZIP files we can still use the IANAL plugin, but the parent should not longer activate it by default because 90% of our artifacts are Jars... Currently activating it leads to WARNINGs with Java 11. WDYT? Konrad > On 5. May 2020, at 20:15, Robert Munteanu <[email protected]> wrote: > > On Tue, 2020-05-05 at 19:11 +0200, Bertrand Delacretaz wrote: >> On Tue, May 5, 2020 at 6:21 PM Konrad Windszus <[email protected]> >> wrote: >>> ...interesting finding but unfortunately last updated in 2008 >>> ( >>> https://search.maven.org/artifact/org.apache.geronimo.genesis.plugins/tools-maven-plugin >>> ). >>> Seems dead as well.... >> >> But that's code that already belongs to the ASF, if someone wants to >> adopt that code in Sling we can get the source code from Maven, >> notify >> the Geronimo PMC to be polite and create a small plugin with just the >> VerifyLegalFilesMojo.java [1], which is not rocket science level code >> ;-) > > +1 > > Robert
