Hi Konrad, On Sun, 2020-12-27 at 13:08 +0100, Konrad Windszus wrote: > I propose to no longer activate the plugin by default. It currently > checks for existence of both LICENSE and NOTICE files in all attached > artifacts. > > For JAR artifacts this is not necessary: > For NOTICE this is always done via the sling-parent pom.xml ( > https://github.com/apache/sling-parent/blob/525ef3128cccc22c39624229158375104a131849/sling-parent/pom.xml#L182 > < > https://github.com/apache/sling-parent/blob/525ef3128cccc22c39624229158375104a131849/sling-parent/pom.xml#L182 > >) > For LICENSE we can use > https://maven.apache.org/enforcer/enforcer-rules/requireFilesExist.html > < > https://maven.apache.org/enforcer/enforcer-rules/requireFilesExist.html > > instead to make sure it always exists on the root level of the > repository (a check not yet performed by IANAL). > Its existence is also ensured by > https://maven.apache.org/apache-resource-bundles/index.html < > https://maven.apache.org/apache-resource-bundles/index.html> being > included in > https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L335 > < > https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L335 > >. > > For ZIP files we can still use the IANAL plugin, but the parent > should not longer activate it by default because 90% of our artifacts > are Jars... Currently activating it leads to WARNINGs with Java 11.
I think that it is worthwhile having some sort of check for the legal artifacts, even though we should not have this problem. I would suggest that we try the Geronimo plugin first. Thanks, Robert
