anchela commented on a change in pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#discussion_r558272122



##########
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##########
@@ -150,6 +164,20 @@ public void addRepoinitExtension(@NotNull 
List<VaultPackageAssembler> packageAss
         }
     }
 
+    private String calculateIntermediatePath(RepoPath intermediatePath) {

Review comment:
       missing notnull
   
   btw: in the method... parent might be null and cause NPE




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to