karlpauls commented on a change in pull request #52:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#discussion_r558293497
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##########
@@ -122,6 +134,8 @@ public void addRepoinitExtension(@NotNull
List<VaultPackageAssembler> packageAss
.filter(entry -> getSystemUser(entry.getKey()).isPresent())
.map(Entry::getValue)
.flatMap(Collection::stream)
+ // paths only should/need to be create with resource-based
access control
+ .filter(((Predicate<AccessControlEntry>)
AccessControlEntry::isPrincipalBased).negate())
Review comment:
Yes, I think we can just wrap the complete block in an if statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
