[ 
https://issues.apache.org/jira/browse/SLING-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272725#comment-17272725
 ] 

Santiago García Pimentel commented on SLING-10096:
--------------------------------------------------

My PR simply adds a parameter to the existing methods, but since this is a 
major change we can discuss an alternate approach if possible.

A possible option is to create a new interface (similar to how sling models has 
InjectAnnotationProcessor and  InjectAnnotationProcessor2)

> Allow the SlingHttpServletRequest in the IncludeGenerator or Sling dynamic 
> includes
> -----------------------------------------------------------------------------------
>
>                 Key: SLING-10096
>                 URL: https://issues.apache.org/jira/browse/SLING-10096
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Santiago García Pimentel
>            Priority: Major
>
> The current interface of the IncludeGenerator of Sling Dynamic Includes only 
> pass the String with the original URL.
> It would be great to allow to pass it also the Request to allow clients to 
> implement more robust/complex implementations. 
> For example, allow to create SDI that use the information of the user making 
> the request



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to