[ https://issues.apache.org/jira/browse/SLING-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284796#comment-17284796 ]
Santiago García Pimentel commented on SLING-10096: -------------------------------------------------- hi [~rombert] sorry for the delay. I had some busy time. you are a right about exported packages. I forgot about that. My need is to have SDIs where the used selector is dynamic based on certain conditions (mostly some user's group). So far I have a work around using two SDIs in a row, but that seems combersome. My idea would be to export the API so to allow to implement additional include generators for more complex scenarios. I think besides what has been done in my PR I would need to export the package with the API. WDYT?, I understand this might be too niche to implement (and as said, I got a workaround) but I think it would be nice to have that option. > Allow the SlingHttpServletRequest in the IncludeGenerator or Sling dynamic > includes > ----------------------------------------------------------------------------------- > > Key: SLING-10096 > URL: https://issues.apache.org/jira/browse/SLING-10096 > Project: Sling > Issue Type: Improvement > Reporter: Santiago García Pimentel > Priority: Major > > The current interface of the IncludeGenerator of Sling Dynamic Includes only > pass the String with the original URL. > It would be great to allow to pass it also the Request to allow clients to > implement more robust/complex implementations. > For example, allow to create SDI that use the information of the user making > the request -- This message was sent by Atlassian Jira (v8.3.4#803005)