stbischof commented on a change in pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r591862497
########## File path: Dockerfile ########## @@ -0,0 +1,50 @@ +# ----------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# ----------------------------------------------------------------------------- + +#Base +FROM adoptopenjdk/openjdk11:alpine-slim +LABEL maintainer Apache Sling + +#ENV +ENV ARTIFACT_CLASH= +ENV CONFIG_CLASH= +ENV REPOSITORY_URLS= +ENV CACHE_DIR= +ENV FRAMEWORK_PROPERTIES= +ENV FEATURE_FILES= +ENV HOME_DIR= +ENV VARIABLE_VALUES= +ENV EXTENSION_CONFIGURATION= +ENV FELIX_FRAMEWORK_VERSION= +ENV OSGI_FRAMEWORK_ARTIFACT= +ENV VERBOSE=warn + + +WORKDIR /opt/run +RUN addgroup -S launcher && adduser -S launcher -G launcher && \ + chown -R launcher:launcher /opt/run + +# copy the packaged jar file into our docker image +COPY ./target/org.apache.sling.feature.launcher-1.1.17-SNAPSHOT.jar /opt/run/org.apache.sling.feature.launcher.jar Review comment: I could do it using maven to have Access to all variables. Like this: https://github.com/fabric8io/docker-maven-plugin/blob/master/samples/helloworld/pom.xml#L65-L79 Would this be a way to go? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
