rombert commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r593086223
##########
File path: pom.xml
##########
@@ -166,4 +166,40 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <profiles>
+ <profile>
+ <id>container</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.34.1</version>
+ <configuration>
+ <images>
+ <image>
+
<name>sling-launcher-container:${project.version}</name>
Review comment:
Not sure what the difference between name and alias is, but we should
use `apache/sling-*`, like we do for the Starter image -
https://hub.docker.com/r/apache/sling . Maybe `apache/sling-feature-launcher`?
##########
File path: pom.xml
##########
@@ -166,4 +166,40 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <profiles>
+ <profile>
+ <id>container</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.34.1</version>
+ <configuration>
+ <images>
+ <image>
+
<name>sling-launcher-container:${project.version}</name>
+ <alias>sling-launcher-container</alias>
+ <build>
+ <contextDir>../../..</contextDir>
+ <dockerFile>Dockerfile</dockerFile>
+ </build>
+ </image>
+ </images>
+ </configuration>
+ <executions>
+ <execution>
+ <id>docker:start</id>
Review comment:
Shouldn't this be `docker:build`?
##########
File path: pom.xml
##########
@@ -166,4 +166,40 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <profiles>
+ <profile>
+ <id>container</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.34.1</version>
+ <configuration>
+ <images>
+ <image>
+
<name>sling-launcher-container:${project.version}</name>
+ <alias>sling-launcher-container</alias>
+ <build>
+ <contextDir>../../..</contextDir>
Review comment:
For some reason this does not work for me
```
[INFO] --- docker-maven-plugin:0.34.1:build (docker:start) @
org.apache.sling.feature.launcher ---
[ERROR] DOCKER> Configured Dockerfile "../../../Dockerfile" (resolved to
"/home/robert/sources/apache/sling/org-apache-sling-feature-launcher/src/main/docker/../../../Dockerfile")
doesn't exist
```
##########
File path: pom.xml
##########
@@ -166,4 +166,40 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <profiles>
+ <profile>
+ <id>container</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.34.1</version>
+ <configuration>
+ <images>
+ <image>
+
<name>sling-launcher-container:${project.version}</name>
+ <alias>sling-launcher-container</alias>
+ <build>
+ <contextDir>../../..</contextDir>
+ <dockerFile>Dockerfile</dockerFile>
+ </build>
+ </image>
+ </images>
+ </configuration>
+ <executions>
+ <execution>
+ <id>docker:start</id>
+ <phase>install</phase>
Review comment:
I think this can be moved to the `package` phase. It will still pick up
the built jars, but we won't need to go through all checks before building the
docker image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
