rombert commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#discussion_r593123262
##########
File path: pom.xml
##########
@@ -166,4 +166,40 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <profiles>
+ <profile>
+ <id>container</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.34.1</version>
+ <configuration>
+ <images>
+ <image>
+
<name>sling-launcher-container:${project.version}</name>
+ <alias>sling-launcher-container</alias>
+ <build>
+ <contextDir>../../..</contextDir>
Review comment:
I think it would be good to set up automated builds for this Docker
image eventually ( not in scope of this PR ). Looking at
https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds,
it looks like the Docker build is basically invoking a top-level Dockerfile.
Maybe we should move the 'launch' Dockerfile where the plug-in expects it and
leave the top-level Dockerfile as an entry point for Dockerhub automated builds?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
