bdelacretaz commented on pull request #9:
URL:
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/9#issuecomment-807115350
You should see my comment ("I think this doesn't work for
SetAclPrincipalBased ") near the bottom of
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/9/files
The tests still pass with the below change, for example, because Operations
are compared using `toString()` which does not necessarily include all
parameters from the input.
diff --git
a/src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java
b/src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java
index c8d8538..aae54ef 100644
---
a/src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java
+++
b/src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java
@@ -51,7 +51,7 @@ public class SetAclPrincipalBased extends AclGroupBase
{
@NotNull
@Override
public String asRepoInitString() {
- String topline = String.format("set principal ACL for %s%s%n",
listToString(principals), getAclOptionsString());
+ String topline = String.format("set principal ACL for %s%s%n",
listToString(principals), "");
return asRepoInit(topline, true);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
