bdelacretaz edited a comment on pull request #9: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/9#issuecomment-808073009
_edit: in the meantime Nicolas Peltier explained why my comment wasn't visible at https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/9/files, I have submitted my review now and that should be fixed)_ The scenario that I'm suggesting to test this "reconstruction of repoinit statements": * Start with one of the existing test cases as currently done in `AsRepoInitTest` * Parse the input script E * Walk the list of `Operation` returned and reconstruct a script A using `asRepoInitString()` * Compare E and A a Strings As is, the comparison will probably fail due to A not including comments and maybe whitespace differences. Normalizing both E and A by removing comments and fixing whitespace should allow for comparing them? I think that's the only way to reliably test this, my `topline` patch above shows that currently some wrong `asRepoInitString()` implementations won't cause the tests to fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
