[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313403#comment-17313403
]
Eric Norman edited comment on SLING-10186 at 4/1/21, 9:47 PM:
--------------------------------------------------------------
These changes seem to contain a regression that now defaults to "debug" log
level (when no -v arg is present) instead of "info" which results in a
significant amount of additional debug logging that should only be present when
the verbose "-v" flag is supplied on the command line.
In other words, this command should log at info level instead of debug level.
{code:java}
java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
target/org.apache.sling.starter-12-SNAPSHOT-oak_tar_far.far{code}
It looks like the handling of the framework properties is incompatible with the
previous version as well. For example, using the
feature-launcher-maven-plugin to override the http.port with a featureProperty
launcher argument doesn't work with the 1.1.18 version of the feature launcher
anymore.
In version 1.1.16 of the feature launcher, a space is expected between the "-D"
and the arg like this (this is how the feature-launcher-maven-plugin does it) :
{code:java}
-D org.osgi.service.http.port=8081
{code}
But in version 1.1.18 the feature launcher only works without any space between
the "-D" and the arg like this:
{code:java}
-Dorg.osgi.service.http.port=8081{code}
was (Author: enorman):
These changes seem to contain a regression that now defaults to "debug" log
level (when no -v arg is present) instead of "info" which results in a
significant amount of additional debug logging that should only be present when
the verbose "-v" flag is supplied on the command line.
In other words, this command should log at info level instead of debug level.
{code:java}
java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
target/org.apache.sling.starter-12-SNAPSHOT-oak_tar_far.far{code}
> Enhance cli parsing on sling-feature-launcher
> ---------------------------------------------
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
> Reporter: Stefan Bischof
> Assignee: Robert Munteanu
> Priority: Major
> Fix For: Feature Model Launcher 1.1.18
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
