[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320503#comment-17320503
]
Eric Norman edited comment on SLING-10186 at 4/13/21, 8:08 PM:
---------------------------------------------------------------
Below would be my preference to maintain compatibility with the 1.1.16 and
earlier for:
{quote}Could you mark the following options with
[*]must
[?]could
[!]not
{quote}
[*] -D a=1
[*] -D a=1 -D b=2
[!] -D a=1,b=2
[!] -D a=1,b=2 -D c=3
[!] -Da=1
[!] -Da=1 -D b=2
[!] -Da=1,b=2
[!] -Da=1,b=2 -Dc=3
[!] -Da=1 -D c=3
I'm not sure what the use case was to allow a csv of name=value pairs within
the same argument. Was this to facilitate using env vars to supply the
configuration? I saw some mention of using env vars for running
sling-feature-launcher as an container, but I didn't see where those env vars
were being read and used. Specifically, is the FRAMEWORK_PROPERTIES env var
supposed to be parsed and treated as a list of properties?
was (Author: enorman):
Below would be my preference to maintain compatibility with the 1.1.16 and
earlier for:
{quote}Could you mark the following options with
[*]must
[?]could
[!]not
{quote}
[*] -D a=1
[*] -D a=1 -D b=2
[!] -D a=1,b=2
[!] -D a=1,b=2 -D c=3
[!] -Da=1
[!] -Da=1 -D b=2
[!] -Da=1,b=2
[!] -Da=1,b=2 -Dc=3
[!] -Da=1 -D c=3
I'm not sure what the use case was to allow a csv of name=value pairs within
the same argument. Was this to facilitate using env vars to supply the
configuration? I saw some mention of using env vars for running
sling-feature-launcher as an container, but I didn't see where those env vars
were being read and used. Specifically, is the FRAMEWORK_PROPERTIES env var
supposed to be a list of properties?
> Enhance cli parsing on sling-feature-launcher
> ---------------------------------------------
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
> Reporter: Stefan Bischof
> Assignee: Robert Munteanu
> Priority: Major
> Fix For: Feature Model Launcher 1.1.18
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
