karlpauls commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608557364
########## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ########## @@ -17,5 +17,5 @@ --> <privileges xmlns:sling="http://sling.apache.org/jcr/sling/1.0"; xmlns:jcr="http://www.jcp.org/jcr/1.0";> <privilege name="sling:replicate"/> - <privilege name="sling:test" abstract="true"><contains name="sling:replicate"/><contains name="jcr:read"/></privilege> + <privilege name="sling:test" abstract="true"><contains name="sling.replicate"/><contains name="jcr.read"/></privilege> Review comment: @anchela, I think there is a problem in the repoinit parser. It will not parse `with <aggregate>` if the aggregate matches any of: ``` (["a"-"z"] | ["A"-"Z"])+ ":" (["a"-"z"] | ["A"-"Z"])+ "/" (["a"-"z"] | ["A"-"Z"] | ["0"-"9"] | ["-"] | ["_"] | ["."] | ["@"] | [":"] | ["+"] | ["/"]) * ":repository" ``` and does not match: ``` (["a"-"z"] | ["A"-"Z"] | ["0"-"9"] | ["-"] | ["_"] | ["."] | ["/"] | [":"] | ["*"]) + ``` That is why I changed the names here to not include a ":" - which obviously is wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
