anchela commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608590392
########## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ########## @@ -17,5 +17,5 @@ --> <privileges xmlns:sling="http://sling.apache.org/jcr/sling/1.0"; xmlns:jcr="http://www.jcp.org/jcr/1.0";> <privilege name="sling:replicate"/> - <privilege name="sling:test" abstract="true"><contains name="sling:replicate"/><contains name="jcr:read"/></privilege> + <privilege name="sling:test" abstract="true"><contains name="sling.replicate"/><contains name="jcr.read"/></privilege> Review comment: @karlpauls , hmmmmmmmmmmm.... just had a quick look at the repo-init-parser tests... the one for registering privileges don't come with aggregates containing a namespace prefix. so.... could well be. https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/master/src/test/resources/testcases/test-42.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
