karlpauls commented on pull request #70:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817705532


   @kwin - I'm not sure we should do this change without providing for an 
option to not write out the artifact. Could we maybe have that cli switch be 
telling us if we want to deploy the artifact or not? Right now, you are making 
drop content configurable but at the same time make it so that the artifact is 
deploy regardless. I think it would be better if that could be configured as 
well.
   
   As a side note, I think this was intended to be used together with the csv 
that is generated by:
   
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/DefaultPackagesEventsEmitter.java
   
   I guess the idea was: package of type content will not be changed, hence, 
not deployed - but listed in the csv. Maybe there should be a better way to 
handle that all together...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to