karlpauls commented on pull request #70:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818516741


   @kwin, I don't disagree that it might be a mistake to ignore "content" 
content packages - however, that is what this option is specifically for 
namely, to drop content. I agree it is a good idea to make it configurable but 
I would suggest we should not generate artifacts for content that is to be 
dropped. 
   
   From a purely conceptional POV, if the resulting feature model doesn't 
reference the artifacts - why should they be "there" in the resulting maven 
repo? 
   
   Now, clearly, sometimes the conceptional POV isn't all that important - 
hence, as I said, I think it would be ok to add another option (or overload the 
drop option) that makes the converter preserve the artifacts despite being 
dropped, but it should be a choice. 
   
   In that case, I guess I have a slight preference to make that a separate 
location to store only the dropped packages (which one could still configure to 
be the same as the other artifacts) but I'm not feeling to strongly about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to