kwin commented on a change in pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r620183887
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java
##########
@@ -126,6 +126,14 @@ public ContentPackage2FeatureModelConverter(boolean
strictValidation) {
}
}
+ public EntryHandlersManager getHandlersManager() {
Review comment:
Hmm, for me that sounds overly complex. Especially as that would mean
processing Sling-Initial-Content would need the following phases:
1. Extract content into 2 content packages
2. Process the 2 content packages again and extract into feature model
Each phases would require some disk I/O and generate temporary files.
That would mean a lot of overhead.Is there any particular issue you see with
the recursive approach inside the `BundleEntryHandler`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
