karlpauls commented on a change in pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r620197453
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java
##########
@@ -126,6 +126,14 @@ public ContentPackage2FeatureModelConverter(boolean
strictValidation) {
}
}
+ public EntryHandlersManager getHandlersManager() {
Review comment:
Yeah, it would be overhead - the benefit would be that we don't have a
second code path hidden inside the handler. I guess I don't right now see an
issue with only calling the handlers again - however, that could obviously
change in the future (not sure if it would be possible for a bundle to have
initial content that could be picked up by the installer again...).
Could we maybe move the processing to the Converter so that at least it is
more in the open what is going on? Something like:
```
public void process(@NotNull String path, Callable<Archive> archiveCallable)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
