kwin commented on a change in pull request #16:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/16#discussion_r638607172
##########
File path:
src/main/java/org/apache/sling/feature/extension/content/ContentHandler.java
##########
@@ -90,20 +92,6 @@ private static ExecutionPlanBuilder
buildExecutionPlan(Collection<Artifact> arti
}
- private static void extractSubPackages(FSPackageRegistry registry,
ExecutionPlanBuilder builder, PackageId pid)
- throws IOException {
- Map<PackageId, SubPackageHandling.Option> subPkgs =
registry.getInstallState(pid).getSubPackages();
Review comment:
This is no longer possible as the getInstallState is a private method.
IMHO this shouldn't be necessary at all, as during registration all subpackages
are automatically registered (compare with
https://issues.apache.org/jira/browse/JCRVLT-524). No need to flatten those
before...
@DominikSuess What was the reason why you treat sub packages here and don't
rely on the inner workings of FSPackageResolver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
