kwin commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/16#issuecomment-850183290
I think with https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/16/commits/c4bf1ced1cb5c6353582422f6d9f566d7443ef68 the shading should be complete (but the JAR is huge). Very hard to tell which dependencies are used at runtime. I wrote an enforcer rule in https://github.com/apache/maven-enforcer/pull/97 to check the class path and the check only emitted the following dependencies missing from the runtime classpath now: 1. org.apache.sling:org.apache.sling.feature.launcher 1. org.osgi:* 1. org.apache.geronimo.specs:geronimo-json_1.1_spec 1. org.apache.felix:org.apache.felix.cm.json 1. org.slf4j:slf4j-api:1.7.25 1. org.apache.felix:org.apache.felix.utils 1. org.apache.felix:org.apache.felix.converter 1. org.apache.sling:org.apache.sling.feature 1. javax.servlet:javax.servlet-api 1. javax.servlet:servlet-api 1. org.jetbrains:annotations All those are either not necessary (the last three) or provided by the Launcher. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
