Buuhuu commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r673800542
##########
File path:
src/test/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtensionTest.java
##########
@@ -99,47 +100,26 @@ public void testDateFormatWithZoneName() {
}
@Test
- public void testDateFormatWithEscapedCharactersJdk8() {
- assumeJdk8();
- assertDate("01 December '18 12:00 AM; day in year: 335; week in year:
49",
- "dd MMMM ''yy hh:mm a; 'day in year': D; 'week in year': w",
- "UTC",
- null);
- }
-
- @Test
- public void testDateFormatWithEscapedCharactersJdk11OrNewer() {
- assumeJdk11OrNewer();
+ @Ignore("ambiguous results depending on the jdk version and implementation
used")
Review comment:
COMPAT is used here as well
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/blob/09b67343e22d06db7cbe01e8c3e8342df1d01d63/pom.xml#L194
It should actually be `COMPAT,SPI` according to
https://www.oracle.com/java/technologies/javase/java9locales.html
> Specifying the system property with "COMPAT,SPI" will have the same
behavior with the prior JDK releases.
`CLDR` is not reliable as it depends on the version used by the particular
implementation java.net jdk11.0.2 gives different results then the oracle jdk11
gives.
The configuration cannot be changed at runtime
> The search order of locale sensitive services can be configured by using
the "java.locale.providers" system property. This system property declares the
user's preferred order for looking up the locale sensitive services separated
by a comma. It is only read at the Java runtime startup, so the later call to
System.setProperty() won't affect the order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
