kwin commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r673811486
##########
File path:
src/test/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtensionTest.java
##########
@@ -99,47 +100,26 @@ public void testDateFormatWithZoneName() {
}
@Test
- public void testDateFormatWithEscapedCharactersJdk8() {
- assumeJdk8();
- assertDate("01 December '18 12:00 AM; day in year: 335; week in year:
49",
- "dd MMMM ''yy hh:mm a; 'day in year': D; 'week in year': w",
- "UTC",
- null);
- }
-
- @Test
- public void testDateFormatWithEscapedCharactersJdk11OrNewer() {
- assumeJdk11OrNewer();
+ @Ignore("ambiguous results depending on the jdk version and implementation
used")
Review comment:
> COMPAT is used here as well
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/blob/09b67343e22d06db7cbe01e8c3e8342df1d01d63/pom.xml#L194
This is for executing the HTL TCK (https://github.com/adobe/htl-tck) which
cannot be changed easily. You are right that this change only fixes
compatibility with Oracle JDKs If you require the TCP with being compatible
with other JDKs then it is much more effort.
For local Sling test we are free to define Tests in a more compatible way
which is IMHO CLRD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
