kwin commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r674114826
##########
File path:
src/test/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtensionTest.java
##########
@@ -99,47 +100,26 @@ public void testDateFormatWithZoneName() {
}
@Test
- public void testDateFormatWithEscapedCharactersJdk8() {
- assumeJdk8();
- assertDate("01 December '18 12:00 AM; day in year: 335; week in year:
49",
- "dd MMMM ''yy hh:mm a; 'day in year': D; 'week in year': w",
- "UTC",
- null);
- }
-
- @Test
- public void testDateFormatWithEscapedCharactersJdk11OrNewer() {
- assumeJdk11OrNewer();
+ @Ignore("ambiguous results depending on the jdk version and implementation
used")
Review comment:
I did also some more tests, JDK8 (Zulu, AdoptOpenJdk and Oracle) ships
with CLDR v27, while JDK11 ships with CLDR v33 (again all three distributions).
The differences are quite fundamental (surprisingly) for instance
https://bugs.openjdk.java.net/browse/JDK-8211262 or the year using 4 digits
instead of 2 in short format style for most locales.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
