Buuhuu commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r673836303
##########
File path:
src/test/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtensionTest.java
##########
@@ -99,47 +100,26 @@ public void testDateFormatWithZoneName() {
}
@Test
- public void testDateFormatWithEscapedCharactersJdk8() {
- assumeJdk8();
- assertDate("01 December '18 12:00 AM; day in year: 335; week in year:
49",
- "dd MMMM ''yy hh:mm a; 'day in year': D; 'week in year': w",
- "UTC",
- null);
- }
-
- @Test
- public void testDateFormatWithEscapedCharactersJdk11OrNewer() {
- assumeJdk11OrNewer();
+ @Ignore("ambiguous results depending on the jdk version and implementation
used")
Review comment:
It was wrong in the JDK8 I guess. Btw not sure if it is intent but
Jenkins builds with jdk8 and runs sonar with jdk11.
short / GMT+02:00 / fr
==> jdk8u301 `01/12/18` vs jdk11.0.12 `01/12/1918`
EEEE, d MMM y / UTC / de
==> jdk8u301 `Sonntag, 1 Dez 1918` vs jdk11.0.12 `Sonntag, 1 Dez. 1918`
dd MMMM ''yy hh:mm a; 'day in year': D; 'week in year': w / UTC
==> jdk8u301 `01 December '18 12:00 AM; day in year: 335; week in year: 49`
==> jdk11.0.12 `01 December '18 12:00 AM; day in year: 335; week in year: 48`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
