Ok, then I shall cancell the release due to multiple issues found. I would like to keep the '12' version so there are a couple ways around this:
1. Cancel the complete release, redo as Sling Starter 13 + friends 2. Cancel the complete release, redo as Sling Starter 12 + friends 3. Cancel the Sling Starter and Archetype releases, continue with other artifacts and only redo Starter and Archetype We typically don't reuse version numbers since someone might already be downloading releases under vote and then not realising that the versions are incorrect. I think that the Starter is a bit different since it has a "marketing" version and would lead to confusion regarding where Sling 12 is. Also the chance of someone pulling it in is very small IMO as it's not a bundle that someone deploys. Therefore I would prefer option 3 3, which has the least amount of friction. The org.apache.sling.starter-12 tag would be dropped and recreated. The archetype will be re-released with a new version number. Thoughts? Thanks, Robert On Thu, 2022-03-03 at 11:46 +0100, Konrad Windszus wrote: > For me only 1 is a blocker, as I think that running in an OSGi R8 > compliant container should also be mentioned in the release notes. > Konrad > > > Am 03.03.2022 um 11:41 schrieb Robert Munteanu > > <[email protected]>: > > > > Hi Konrad, > > > > > On Wed, 2022-03-02 at 18:47 +0100, Konrad Windszus wrote: > > > And I found another blocker: > > > https://issues.apache.org/jira/browse/SLING-11173 < > > > https://issues.apache.org/jira/browse/SLING-11173> which deserves > > > fixing prior to release. > > > Therefore voting -1. > > > > Thanks for looking into this and for raising issues. > > > > I'd like to make sure I understand how severe these bugs are. Not > > necessarilly because of the time needed to redo the release, but > > because I'd like to keep the '12' version for the next Starter > > release > > and I'm not sure that this is feasible. > > > > Current we have > > > > 1. SLING-11173 - Wrong version of org.osgi.framework exported (OSGi > > R7 > > instead of OSGi R8) > > 2. SLING-11172 - Make API documentation link point to the (not yet > > published) Sling 12 javadoc > > 3. SLING-11171 - WARN "The provided service user id 'serviceuser-- > > org.apache.sling.auth.core' is not a known JCR system user id and > > therefore not allowed in the Sling Service User Mapper." > > 4. SLING-11168 - Sling Starter 12: Unable to launch Composum > > > > I'll try to assess the impact for each of these, let me know if > > these > > match your understanding. > > > > 1. Bundles using OSGi R8 specific features won't work in the Sling > > Starter 12 version. > > 2. Anyone using the 'API docs' version of the Starter will find the > > docs for the old 11 version instead. > > 3. I am not sure what the impact is here. I traced the code > > JcrSystemUserValidator → ServiceUserMapperImpl → > > AbstractSlingRepository2 but I don't understand what happens next. > > Technically loginService should fail, but I do not see evidence of > > that > > in the logs. > > 4. Still up for discussion. I saw that it fails for Stefan on > > Windows, > > but I could not reproduce it in a VM. Sergiu also mentioned in the > > issue that he saw it happen sporadically. > > > > I personally don't see 1 and 2 as blockers. For 3 and 4 I would > > like to > > understand the impact before cancelling the release. > > > > Thanks, > > Robert > > > > > > > > Konrad > > > > > > > > On 2. Mar 2022, at 18:28, Konrad Windszus <[email protected]> > > > > > wrote: > > > > > > > > Hi, > > > > I cannot reproduce the issue from Stefan on my Mac. > > > > But I would like to fix the wrong API documentation > > > > (https://issues.apache.org/jira/browse/SLING-11172 < > > > > https://issues.apache.org/jira/browse/SLING-11172>) and also > > > > the > > > > WARN around the missing/wrong service user for Sling Auth Core > > > > (https://issues.apache.org/jira/browse/SLING-11171 < > > > > https://issues.apache.org/jira/browse/SLING-11171>). > > > > For the former I already created a PR for the latter it would > > > > be > > > > good if someone more familiar with Auth Core could have a look. > > > > I would rather tend to wait for those issues (and potentially > > > > Stefan one’s if we figure out the root cause) until we release > > > > Sling Starter 12. > > > > > > > > Konrad > > > > > > > > > > > > > > > > > On 25. Feb 2022, at 17:37, Robert Munteanu > > > > > <[email protected]> > > > > > wrote: > > > > > > > > > > Hi, > > > > > > > > > > We solved 80 issues in these releases (not accounting for > > > > > duplicates): > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/SLING/fixforversion/12344080 > > > > > (57) > > > > > https://issues.apache.org/jira/browse/SLING/fixforversion/12348435 > > > > > (3) > > > > > https://issues.apache.org/jira/browse/SLING/fixforversion/12345675 > > > > > (7) > > > > > https://issues.apache.org/jira/browse/SLING/fixforversion/12348357 > > > > > (6) > > > > > https://issues.apache.org/jira/browse/SLING/fixforversion/12348291 > > > > > (7) > > > > > > > > > > There is no Jira version for the test-fragment bundle, but > > > > > I've > > > > > included it in the release since we keep the same version for > > > > > all > > > > > the > > > > > testing projects. > > > > > > > > > > Staging repository: > > > > > https://repository.apache.org/content/repositories/orgapachesling-2604 > > > > > > > > > > You can use this UNIX script to download the release and > > > > > verify > > > > > the > > > > > signatures: > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > > > > > Usage: > > > > > sh check_staged_release.sh 2604 /tmp/sling-staging > > > > > > > > > > Please vote to approve this release: > > > > > > > > > > [ ] +1 Approve the release > > > > > [ ] 0 Don't care > > > > > [ ] -1 Don't release, because ... > > > > > > > > > > This majority vote is open for at least 72 hours. > > > > > > > > > > Thanks, > > > > > Robert > > > > > > > > > >
