enapps-enorman commented on a change in pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-maintenance/pull/2#discussion_r828235276
##########
File path: pom.xml
##########
@@ -31,7 +31,9 @@
<description>Maintenance jobs for the JCR</description>
<properties>
+ <sling.java.version>8</sling.java.version>
<project.build.outputTimestamp>2021-04-15T18:14:05Z</project.build.outputTimestamp>
+ <oak.version>1.40.0</oak.version>
Review comment:
Is this oak.version value intended to be the new minimum version of oak
that works with this bundle? Was there some reason to change the minimum
version from oak 1.8.8 to 1.40.0?
##########
File path: pom.xml
##########
@@ -129,25 +131,24 @@
<dependency>
<groupId>org.apache.jackrabbit</groupId>
<artifactId>oak-core</artifactId>
- <version>1.8.8</version>
+ <version>${oak.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.jackrabbit</groupId>
<artifactId>oak-jcr</artifactId>
- <version>1.8.8</version>
+ <version>${oak.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.api</artifactId>
- <version>2.18.4</version>
+ <version>2.24.0</version>
Review comment:
What makes changing the minimum version of this dependency necessary?
##########
File path: pom.xml
##########
@@ -117,7 +119,7 @@
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.healthcheck.api</artifactId>
- <version>2.0.0</version>
+ <version>2.0.4</version>
Review comment:
What makes changing the minimum version of this dependency necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
