enapps-enorman commented on a change in pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-maintenance/pull/2#discussion_r828539713
##########
File path: pom.xml
##########
@@ -129,25 +131,24 @@
<dependency>
<groupId>org.apache.jackrabbit</groupId>
<artifactId>oak-core</artifactId>
- <version>1.8.8</version>
+ <version>${oak.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.jackrabbit</groupId>
<artifactId>oak-jcr</artifactId>
- <version>1.8.8</version>
+ <version>${oak.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.api</artifactId>
- <version>2.18.4</version>
+ <version>2.24.0</version>
Review comment:
Ok, just be aware that changing this has altered the Import-Package
instruction in the manifest for the used packages from this artifact.
For example:
_org.apache.sling.api.resource;version="[2.11,3)"_ has changed to:
_org.apache.sling.api.resource;version="[2.13,3)"_
In general, if it still works with the older version and there are no
security bugs or other compelling reasons for switching to the new version then
it may be better to remain depending on the older version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
