[ 
https://issues.apache.org/jira/browse/SLING-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057566#comment-13057566
 ] 

Justin Edelson edited comment on SLING-2112 at 6/30/11 3:35 PM:
----------------------------------------------------------------

a few comments...
* do you have a test case for this? just asking because the initial issue 
report mentioned a test and it'd be great to have one
* please use spaces, not tabs in patches
* I'm not sure RequestUtil is the best place for this. What about ResponseUtil 
instead?

      was (Author: justinedelson):
    a few comments...
* do you have a test case for this? just asking because the initial issue 
report mentioned a test and it'd be great to have one
* please use spaces, not tabs in patches
* I'm not sure ResourceUtil is the best place for this. What about ResponseUtil 
instead?
  
> Adding support for managing If-Modified-Since in request/response headers
> -------------------------------------------------------------------------
>
>                 Key: SLING-2112
>                 URL: https://issues.apache.org/jira/browse/SLING-2112
>             Project: Sling
>          Issue Type: New Feature
>          Components: API
>            Reporter: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2112.patch.txt, SLING-2112.patch2.txt
>
>
> Adding support for managing If-Modified-Since in request/response headers to 
> the Sling API RequestUtil.
> Proposed Patch and Junit tests to follow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to