kwin commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r974159705
##########
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##########
@@ -131,7 +133,7 @@ public void importFromStream(ResourceResolver
resourceResolver, InputStream inpu
Archive archive = null;
try {
session = getSession(resourceResolver);
- ImportOptions importOptions =
VltUtils.getImportOptions(aclHandling, cugHandling, importMode,
autosaveThreshold, strict);
+ ImportOptions importOptions =
VltUtils.getImportOptions(aclHandling, cugHandling, importMode,
autosaveThreshold, strict, idConflictPolicy);
ErrorListener errorListener = new ErrorListener();
importOptions.setListener(errorListener);
Importer importer = new Importer(importOptions);
Review Comment:
what about the other defaults:
- boolean isStrictByDefault
- boolean overwritePrimaryTypesOfFoldersByDefault
You should either inherit form the Packaging OSGi configuration or make them
maintainable as well IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
