ManasMaji commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975044699
##########
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##########
@@ -131,7 +133,7 @@ public void importFromStream(ResourceResolver
resourceResolver, InputStream inpu
Archive archive = null;
try {
session = getSession(resourceResolver);
- ImportOptions importOptions =
VltUtils.getImportOptions(aclHandling, cugHandling, importMode,
autosaveThreshold, strict);
+ ImportOptions importOptions =
VltUtils.getImportOptions(aclHandling, cugHandling, importMode,
autosaveThreshold, strict, idConflictPolicy);
ErrorListener errorListener = new ErrorListener();
importOptions.setListener(errorListener);
Importer importer = new Importer(importOptions);
Review Comment:
@tmaret should we also read the value for `strict` from the same
`PackageImpl` config (and remove the property from
`VaultDistributionPackageBuilderFactory`'s config)? I had used configuration
admin to read the value for `idConflictPolicy` from the `PackageImpl` config
earlier, but then chose this approach, since it would be confusing for the user
if only some of the values (`idConflictPolicy` &
`overwritePrimaryTypesOfFoldersByDefault` from the `PackageImpl` config are
being applied, while the value for `strict` is being applied from some other
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
