Kronnox commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024175976
##########
src/main/java/org/apache/sling/testing/Constants.java:
##########
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
*/
public static final String EXPECTED_STATUS = "expected_status";
+
+ /**
+ * User Agent
+ */
+ public static final String SLING_CLIENT_USERAGENT_TITLE =
"sling-testing-client";
Review Comment:
Let's discuss that.
The initial reasoning behind the proposal was users being confused with the
`JAVA` agent since it's not really descriptive in any way and doesn't hint to
where the requests are coming from. I agree on it being risky to change the
default, when it comes to existing log-filters and such. Other test relying on
these test to have a specific User-Agent sounds rather unlikely to me, but
you're right; guess you can never be sure...
IMHO just leaving it as it is, isn't a good solution either. Do we have any
option to leave it as is for current users and only include the change with new
installations; some properties file or something? Anyways, I think this is
rather a problem of communicating the change, than a technical limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
